kayg/calternal
Watch
1
0
Fork
You've already forked calternal
 0
Code Issues 191 Pull requests 61 Projects Releases Packages Wiki Activity Actions 20

Narrow window: no hover handle; link pill padding (#469) #573

Closed
kayg wants to merge 0 commits from issue/469-narrow-handle into dev
pull from: issue/469-narrow-handle
merge into: kayg:dev
Conversation 1 Commits - Files changed -
kayg commented 2026-10-18 07:37:14 +00:00
Owner
Copy link

Closes #469.

  • In the phone layout (759px and under, the app's one breakpoint) the block hover handle and pill never show, even with a mouse (cm.css).
  • Link pill padding is now .1em .45em with margins cancelling it at rest, so the last letter no longer touches the border and the pill appearing moves no text. Measured gaps at 1440: left 8.6 px, right 8.6 px.
  • links-parity.spec.ts padding expectation updated to the new values (kayg's request); other approved link values unchanged.

Tests (--no-deps --workers=1, links, links-look, links-parity, missing-links, editor, touch-select): chromium-390 53 passed/8 skipped, chromium-1440 44/17, webkit-390 51/10, webkit-1440 42/19. svelte-check: 0 errors.

Screenshots are on the issue.

🤖 Generated with Claude Code

https://claude.ai/code/session_01U5oTUycqAh7DT72mdSUztk

Closes #469. - In the phone layout (759px and under, the app's one breakpoint) the block hover handle and pill never show, even with a mouse (cm.css). - Link pill padding is now .1em .45em with margins cancelling it at rest, so the last letter no longer touches the border and the pill appearing moves no text. Measured gaps at 1440: left 8.6 px, right 8.6 px. - links-parity.spec.ts padding expectation updated to the new values (kayg's request); other approved link values unchanged. Tests (--no-deps --workers=1, links, links-look, links-parity, missing-links, editor, touch-select): chromium-390 53 passed/8 skipped, chromium-1440 44/17, webkit-390 51/10, webkit-1440 42/19. svelte-check: 0 errors. Screenshots are on the issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U5oTUycqAh7DT72mdSUztk
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Link parity: pill padding .1em .45em on kayg's request (#469)
Some checks failed
CI / web (pull_request) Failing after 11s
Details
CI / server (pull_request) Successful in 28s
Details
CI / rust (pull_request) Successful in 2m41s
Details
9918aba7e9 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kayg commented 2026-10-18 12:07:48 +00:00
Author
Owner
Copy link

Landed in train AB, #580.

Train AB ran the full suite: fmt, clippy, workspace tests (502 passed, 0 failed), the build, svelte-check, and every Playwright project in parallel shards.

  • First run discarded: the Rust steps hadn't compiled (a broken shared environment file), so e2e had used an old binary. The train script now stops at the first failing Rust step.
  • Rerun: every shard passed except two tests that failed under load:
    • swipe-rows:116 passed 60 of 60 repeated alone;
    • missing-links:155 (page closed) passed 54 of 54.
  • webkit-390 shard 3/3: it collided on a port, was rerun alone, and passed 94 of 94.

Contents:

  • #576: the block-selection tint covers exactly its block;
  • #578: the phone layout never scrolls sideways;
  • #575: swipe rows;
  • #573: narrow handle and link pill padding;
  • #574: saves no longer copy the whole note, with the independent review's crash tests.
Landed in train AB, #580. Train AB ran the full suite: fmt, clippy, workspace tests (502 passed, 0 failed), the build, svelte-check, and every Playwright project in parallel shards. - **First run discarded:** the Rust steps hadn't compiled (a broken shared environment file), so e2e had used an old binary. The train script now stops at the first failing Rust step. - **Rerun:** every shard passed except two tests that failed under load: - `swipe-rows:116` passed 60 of 60 repeated alone; - `missing-links:155` (page closed) passed 54 of 54. - **webkit-390 shard 3/3:** it collided on a port, was rerun alone, and passed 94 of 94. Contents: - #576: the block-selection tint covers exactly its block; - #578: the phone layout never scrolls sideways; - #575: swipe rows; - #573: narrow handle and link pill padding; - #574: saves no longer copy the whole note, with the independent review's crash tests.
kayg closed this pull request 2026-10-18 12:07:48 +00:00
Some checks failed
CI / web (pull_request) Failing after 11s
Details
CI / server (pull_request) Successful in 28s
Details
CI / rust (pull_request) Successful in 2m41s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Rust server

  
design
Mockups, UI and TASTE

  
docs
ADRs, CONTEXT, TASTE

  
idea
Parked idea, never worked until promoted

  
infra
Deploy, CI, VMs

  
perf
Performance and budgets

  
reliability
Data integrity, corruption traps

  
web
Web client

No labels
backend
design
docs
idea
infra
perf
reliability
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal!573
No description provided.