port: contacts edit fields (approved mockup, 3/4)

kayg commented

2026-11-02 10:14:09 +00:00

Owner

Slice 3 of 4 of the Contacts port. Stacked on #843 (base port/contacts-card; retarget to dev as the ones below merge).

What it is

Editing the card, with no edit mode: a line opens where it is.

Desktop: click copies (after a short beat, so a double-click can edit instead), double-click edits the line, hover ⋯ has the action, Copy and Edit. Phone: tap does the action, hold lists Copy, Edit and the action.
Enter or leaving a line keeps what was typed; Escape puts it back; an emptied line goes away, and its group with it when it was the last. While a line is open a "+ add phone" row sits under its group.
Add field… in the card's ⋯: phone, email, address, website, date, birthday, social, related name, nickname, pronouns, department (company and job title open the heading). Edit name: name, job title and company open in place. Add timestamp and double-click / tap on the Notes open them for typing; Notes made when there are none.
Pure edits in card.ts (tested, byte-exact elsewhere): set a line's label and value, remove a line and its emptied group, add to a group or start one (also in a note with no final newline or with CRLF), set/add/clear a once-only fact, rename the heading, rewrite the Notes. Only the lines an edit means to change are different afterwards (a test checks every other line of the note, for LF, CRLF and no final newline).
Writing (save.ts): the note is read fresh, one edit is made, and the whole text goes back through notes.replace with the version it was read at (the normal save path). A 409/412 reads again and makes the edit once more on the new text. The line to change is found again by what it says, so an edit never lands on another line.
The contact icons now register with the shared Icon (a three-line registerIcons hook) when the screen loads: menus that named an icon the set did not know drew the notes icon.

Decisions

Renaming only rewrites the heading: the note's file follows its heading (as for every note), so no contact-specific rename.
A line with no label whose value contains : gets its kind's usual label, so it is never read back as a label.
"Pending" mockup parts that need no backend but are not here: field templates, the hover "+" on a line, Mark as deceased, alternate birthday, phonetic names, name parts (prefix/middle/suffix). Listed in the final report.

Gates (CI=1 --retries=0, through ~/bin/slot, head `9c2571cc`)

Same as the stack top (below): bun run check 0 errors; vitest 152 passed; contacts-edit.spec.ts (edit a line and only that line changes; Escape; empty line removes its group; Add field starts a group and a once-only line; rename; Notes with a timestamp) passes in chromium-1440/390 and webkit-1440/390 with the rest of the stack.

Budget (kayg approved, 2026-11-08 08:20 IST): kayg approved raising the lazy budget total, up to 543.9 KiB. perf/budgets.json in this PR sets each named lazy line to the largest size measured over the 17 approved ports after trimming (rounded up to 0.01 KiB) and the total to the sum of the lines (543.25 KiB). The same file is in the first PR of every stack, so whichever merges first carries it. First paint is judged separately and has not been raised.

Slice 3 of 4 of the Contacts port. **Stacked on #843** (base `port/contacts-card`; retarget to `dev` as the ones below merge). ## What it is Editing the card, with no edit mode: a line opens where it is. - **Desktop**: click copies (after a short beat, so a double-click can edit instead), double-click edits the line, hover ⋯ has the action, Copy and Edit. **Phone**: tap does the action, hold lists Copy, Edit and the action. - Enter or leaving a line keeps what was typed; Escape puts it back; an emptied line goes away, and its group with it when it was the last. While a line is open a "+ add phone" row sits under its group. - **Add field…** in the card's ⋯: phone, email, address, website, date, birthday, social, related name, nickname, pronouns, department (company and job title open the heading). **Edit name**: name, job title and company open in place. **Add timestamp** and double-click / tap on the Notes open them for typing; Notes made when there are none. - **Pure edits** in `card.ts` (tested, byte-exact elsewhere): set a line's label and value, remove a line and its emptied group, add to a group or start one (also in a note with no final newline or with CRLF), set/add/clear a once-only fact, rename the heading, rewrite the Notes. Only the lines an edit means to change are different afterwards (a test checks every other line of the note, for LF, CRLF and no final newline). - **Writing** (`save.ts`): the note is read fresh, one edit is made, and the whole text goes back through `notes.replace` with the version it was read at (the normal save path). A 409/412 reads again and makes the edit once more on the new text. The line to change is found again by what it says, so an edit never lands on another line. - The contact icons now register with the shared `Icon` (a three-line `registerIcons` hook) when the screen loads: menus that named an icon the set did not know drew the notes icon. ## Decisions - Renaming only rewrites the heading: the note's file follows its heading (as for every note), so no contact-specific rename. - A line with no label whose value contains `: ` gets its kind's usual label, so it is never read back as a label. - "Pending" mockup parts that need no backend but are not here: field templates, the hover "+" on a line, Mark as deceased, alternate birthday, phonetic names, name parts (prefix/middle/suffix). Listed in the final report. ## Gates (CI=1 --retries=0, through ~/bin/slot, head `9c2571cc`) Same as the stack top (below): `bun run check` 0 errors; vitest 152 passed; `contacts-edit.spec.ts` (edit a line and only that line changes; Escape; empty line removes its group; Add field starts a group and a once-only line; rename; Notes with a timestamp) passes in chromium-1440/390 and webkit-1440/390 with the rest of the stack. **Budget (kayg approved, 2026-11-08 08:20 IST):** kayg approved raising the lazy budget total, up to 543.9 KiB. `perf/budgets.json` in this PR sets each named lazy line to the largest size measured over the 17 approved ports after trimming (rounded up to 0.01 KiB) and the total to the sum of the lines (543.25 KiB). The same file is in the first PR of every stack, so whichever merges first carries it. First paint is judged separately and has not been raised.

kayg added 4 commits

2026-11-02 10:14:09 +00:00

Contacts: edit fields (slice 3): a line opens where it is, add field, name, Notes c1492fdae6

Pure edits in card.ts (set a line, remove a line and its emptied group, add to a group or start one, once-only facts, heading, Notes),
written back through notes.replace with the version read (save.ts); the card's menu adds lines; the contact icons register with the
shared Icon when the screen loads.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Contacts edit specs 4be6a1d49b

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Contacts edit spec: click the card's name, not any h1 59b35f368e

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Contacts edit spec: blur the Notes box itself (WebKit keeps focus on a click of plain text)

CI / server (pull_request) Has been cancelled

Details

CI / rust (pull_request) Has been cancelled

Details

CI / web (pull_request) Has been cancelled

Details

Markdown extraction contract / markdown-native-contract (pull_request) Has been cancelled

Details

Markdown extraction contract / markdown-editor-contract (pull_request) Has been cancelled

Details

9c2571cc5e

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

check	dev `3f079de39`	this PR
first paint, plain brotli	227240 B	227156 B (−84 B)
first paint, normalised	226769 B	226687 B (−82 B)
budget total	506.34 KiB	512.03 KiB (≤ 543.9)
bundle gate		passes

check	dev `5a4e2dd0f`	this PR
first paint, plain brotli	227848 B	227535 B (−313 B)
first paint, hash-normalised	227107 B	227260 B (+153 B; relettering noise, plain is under)
first-screen CSS	18234 B	18234 B
budget total	525.01 KiB	530.74 KiB (≤ 543.9): ContactsScreen 13.68 → 14.31, new Timeline 0.83, cardmenu 0.58, edits 1.26, logic 1.74, names 0.65
bundle gate		passes

Rows
Columns

port: contacts edit fields (approved mockup, 3/4) #848

What it is

Decisions

Gates (CI=1 --retries=0, through ~/bin/slot, head 9c2571cc)

READY FOR MERGE: Contacts edit (head c49435750)

READY FOR MERGE: Contacts edit (head f09390a14)

Pull request closed

Gates (CI=1 --retries=0, through ~/bin/slot, head `9c2571cc`)

READY FOR MERGE: Contacts edit (head `c49435750`)

READY FOR MERGE: Contacts edit (head `f09390a14`)