P1: Restore the async Photos Sidecar test attribute (#720) #894

Open
opened 2026-10-02 17:36:36 +00:00 by kayg · 0 comments
Owner

Independent review of #720, target 0668a70f2 on job/audiophotos-720.

P1: the Photos test target cannot compile.

Evidence: crates/plugins/photos/src/index.rs:2204 changes #[tokio::test] to #[test]. Line 2205 still declares async fn reads_xmp_from_indexed_lightroom_sidecar_path. Lines 2216 and 2226 await file writes. The standard Rust test attribute does not support async test functions. This change is in commit 47b2590a8.

Expected: the existing Sidecar test must still compile and run. The new #720 regression test must be runnable. The owner requires passing crate gates and forbids weakening existing tests.

Fix: restore #[tokio::test]. Keep the existing writes and assertions.

Validation after repair: cargo clippy -p calternal-plugin-photos --all-targets -- -D warnings and cargo test -p calternal-plugin-photos. The focused test must run rather than be removed or ignored.

This is a static finding. LIGHT rules prohibit builds and tests in this review. No compiler output is claimed.

Duplicate check: searched all issue states for reads_xmp_from_indexed_lightroom_sidecar_path; no matching issue was returned.

Independent review of #720, target `0668a70f2` on `job/audiophotos-720`. P1: the Photos test target cannot compile. Evidence: `crates/plugins/photos/src/index.rs:2204` changes `#[tokio::test]` to `#[test]`. Line 2205 still declares `async fn reads_xmp_from_indexed_lightroom_sidecar_path`. Lines 2216 and 2226 await file writes. The standard Rust test attribute does not support async test functions. This change is in commit `47b2590a8`. Expected: the existing Sidecar test must still compile and run. The new #720 regression test must be runnable. The owner requires passing crate gates and forbids weakening existing tests. Fix: restore `#[tokio::test]`. Keep the existing writes and assertions. Validation after repair: `cargo clippy -p calternal-plugin-photos --all-targets -- -D warnings` and `cargo test -p calternal-plugin-photos`. The focused test must run rather than be removed or ignored. This is a static finding. LIGHT rules prohibit builds and tests in this review. No compiler output is claimed. Duplicate check: searched all issue states for `reads_xmp_from_indexed_lightroom_sidecar_path`; no matching issue was returned.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kayg/calternal#894
No description provided.